Changes requested for AppCenter

cassidyjames commented

2018-04-09 23:55:43 +00:00

(Migrated from github.com)

Thanks for submitting your app! I have a couple of changes to request:

It needs to depend on or include Flatpak in order to be distributed through AppCenter; otherwise, users install it and cannot do anything with flatpakref files. (They get Error: Failed to execute child process “flatpak” (No such file or directory) in the Terminal)
You should register your app with flatpakref MIME type so opening one from the web or local system automatically opens Hujing. Right now, users have to open your app first, then navigate to the flatpakref file.

Once you've addressed these items, please make a new release on GitHub and resubmit your app to AppCenter. Thanks again!

Thanks for submitting your app! I have a couple of changes to request: - [x] It needs to depend on or include Flatpak in order to be distributed through AppCenter; otherwise, users install it and cannot do anything with flatpakref files. (They get `Error: Failed to execute child process “flatpak” (No such file or directory)` in the Terminal) - [x] You should register your app with flatpakref MIME type so opening one from the web or local system automatically opens Hujing. Right now, users have to open your app _first_, then navigate to the flatpakref file. Once you've addressed these items, please make a new release on GitHub and resubmit your app to AppCenter. Thanks again!

👍 1

cassidyjames commented

2018-04-10 17:01:26 +00:00

(Migrated from github.com)

As a note, flatpak is included in 18.04, so this app should work fine in Juno (assuming it's a new enough version of flatpak included).

albe-rosado commented

2018-04-10 17:37:28 +00:00

(Migrated from github.com)

Thanks Cassidy, good to know. I'm working on the missing features and will
make another release soon, thank you for your support.

Thanks Cassidy, good to know. I'm working on the missing features and will make another release soon, thank you for your support.

cassidyjames commented

2018-04-22 18:26:00 +00:00

(Migrated from github.com)

@albe-rosado thanks for taking the time to update and re-release your app for AppCenter. However, we've had to request changes for it as well.

https://github.com/albe-rosado/Hujing/compare/v0.1.23...v0.1.29#diff-4c24823d6727382406a3e88f19f57b15R190

As you'll find in the wiki:

Your app must not attempt to modify, replace, or append software sources on the target system.

This includes the Flatpak PPA from Launchpad; adding a third party software source is not considered secure, and is giving root access to users' machines to the maintainer of that repository.

For Flatpak, I wonder if waiting to release the app for Juno would make the most sense; Flatpak is included in the repositories, and you can use standard Debian packaging to depend on it instead of manually installing it or adding PPAs in the middle of your app.

@albe-rosado thanks for taking the time to update and re-release your app for AppCenter. However, we've had to request changes for it as well. https://github.com/albe-rosado/Hujing/compare/v0.1.23...v0.1.29#diff-4c24823d6727382406a3e88f19f57b15R190 As you'll find [in the wiki](https://github.com/elementary/houston/wiki/Before-You-Publish#technical-requirements): >Your app must not attempt to modify, replace, or append software sources on the target system. This includes the Flatpak PPA from Launchpad; adding a third party software source is not considered secure, and is giving root access to users' machines to the maintainer of that repository. For Flatpak, I wonder if waiting to release the app for Juno would make the most sense; Flatpak is included in the repositories, and you can use standard Debian packaging to depend on it instead of manually installing it or adding PPAs in the middle of your app.

albe-rosado commented

2018-04-22 18:28:26 +00:00

(Migrated from github.com)

Well, I guess will have to wait for Juno then, thanks Cassidy.

albe-rosado commented

2018-04-22 18:30:28 +00:00

(Migrated from github.com)

Flatpak is not included in the repos on elementary or Ubuntu, so depending on it will fail when building.

cassidyjames commented

2018-04-22 18:35:12 +00:00

(Migrated from github.com)

@albe-rosado Flatpak is included in the repos as of Ubuntu 18.04 and elementary OS 5.0 Juno. If you're targeting 16.04/Loki, I suppose you could do something like what @davidmhewitt does with Torrential and Transmission, and use a git submodule for your dependency. I'm not 100% sure how that works, but David might be able to give you pointers. The best bet, however, is likely waiting for the Juno beta and building your app for 18.04/Juno.

@albe-rosado Flatpak is included in the repos as of Ubuntu 18.04 and elementary OS 5.0 Juno. If you're targeting 16.04/Loki, I suppose you could do something like what @davidmhewitt does with [Torrential](https://github.com/davidmhewitt/torrential) and Transmission, and use a git submodule for your dependency. I'm not 100% sure how that works, but David might be able to give you pointers. The best bet, however, is likely waiting for the Juno beta and building your app for 18.04/Juno.

albe-rosado commented

2018-04-22 18:38:02 +00:00

(Migrated from github.com)

Cool

Rows
Columns

Changes requested for AppCenter #29